Allow multiple callbacks rack #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As seen here: omniauth/omniauth-oauth2#93 https://docs.microsoft.com/en-us/graph/tutorials/ruby?tutorial-step=3 This way we can have multiple callback urls setup in Azure AD.
tavyy
force-pushed
the
allow-multiple-callbacks-rack
branch
from
43f02c7
to
e6054cf
Compare
tavyy
force-pushed
the
allow-multiple-callbacks-rack
branch
from
7e61fb3
to
e6054cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We want to build the redirect_uri in Omniauth ideally dynamically by parsing the requests at the rack level.
Check: https://github.com/omniauth/omniauth/blob/c2380ae848ce4e0e39b4bb94c5b8e3fd0a544825/lib/omniauth/strategy.rb to understand how that's done.
omniauth/omniauth-oauth2#93
https://docs.microsoft.com/en-us/graph/tutorials/ruby?tutorial-step=3
We also leave the option to explicitly set the
redirect_urias options.This will allow us to have multiple callback urls setup in Azure AD.