generated from DFE-Digital/govuk-rails-boilerplate
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add methods to identify archivable participants #4806
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review app deployed to https://cpd-ecf-review-4806-web.test.teacherservices.cloud |
ethax-ross
force-pushed
the
3061-identity-participants-for-archiving
branch
from
May 17, 2024 13:02
86c7235
to
e823e47
Compare
ethax-ross
force-pushed
the
3061-identity-participants-for-archiving
branch
from
May 20, 2024 13:55
e823e47
to
5e199aa
Compare
ethax-ross
force-pushed
the
3061-identity-participants-for-archiving
branch
from
May 20, 2024 19:57
5e199aa
to
6d44c56
Compare
ethax-ross
force-pushed
the
3061-identity-participants-for-archiving
branch
3 times, most recently
from
May 21, 2024 11:30
ceafedf
to
7995b10
Compare
ethax-ross
force-pushed
the
3061-identity-participants-for-archiving
branch
from
May 21, 2024 12:09
7995b10
to
d3e2347
Compare
ethax-ross
force-pushed
the
3061-identity-participants-for-archiving
branch
from
May 22, 2024 08:40
d3e2347
to
4f27f99
Compare
ethax-ross
force-pushed
the
3061-identity-participants-for-archiving
branch
from
May 22, 2024 08:45
4f27f99
to
14e6930
Compare
ethax-ross
force-pushed
the
3061-identity-participants-for-archiving
branch
from
May 22, 2024 08:54
14e6930
to
a076c7d
Compare
ethax-ross
force-pushed
the
3061-identity-participants-for-archiving
branch
from
May 22, 2024 09:32
a076c7d
to
d8735b3
Compare
As part of the multi cohort work we want to archive certain participants in a 'closed' cohort (identified by being 3 years prior to the current cohort or earlier). The criteria is as follows: ECTS: ``` 2021 cohort (according to their schedule -> cohort) Profile has no declarations where declaration state is one of eligible/payable/paid/awaiting_clawback/clawed_back Participant has only FIP induction records Induction completion date is null Induction start date is earlier than 1/9/2021 ``` Mentors: ``` 2021 cohort (according to their schedule -> cohort) Profile has no declarations where declaration state is one of eligible/payable/paid/awaiting_clawback/clawed_back Participant has only FIP induction records Mentor funding end date is null Has no mentees ``` Add a scope find archivable participant profiles and a method to check if a single profile can be archived.
ethax-ross
force-pushed
the
3061-identity-participants-for-archiving
branch
from
May 22, 2024 12:24
d8735b3
to
c8a2d7c
Compare
cwrw
approved these changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Jira-3061
As part of the multi cohort work we want to archive participants in a 'closed' cohort (identified by being 3 years prior to the current cohort or earlier). They must have either no declarations or only unbillable (ineligible/voided/submitted) declarations.
Changes proposed in this pull request
Add a scope find archivable participant profiles and a method to check if a single profile can be archived.
Guidance to review
Here are the numbers from production; just waiting on Nathan verifying these look correct and checking a few samples: