Restore funded_place if modified after acceptance #4790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app deployed to https://cpd-ecf-review-4790-web.test.teacherservices.cloud |
cwrw
reviewed
May 14, 2024
| @@ -16,6 +16,9 @@ def call | |||
| return self unless valid? | |||
|
|
|||
| npq_application.update!(lead_provider_approval_status: "rejected") | |||
| if FeatureFlag.active?(:npq_capping) && npq_application.funded_place? | |||
There was a problem hiding this comment.
ah this is the wrong service, can we please only do this on the ChangeToPending service and set this to nil please as per the ticket
There was a problem hiding this comment.
Addressed in 7ad22c1
pmanrubia
force-pushed
the
CPDLP-3071-npq-capping-update-change-to-pending-service-to-unset-funded-place-if-set
branch
from
d17199d
to
7ad22c1
Compare
pmanrubia
force-pushed
the
CPDLP-3071-npq-capping-update-change-to-pending-service-to-unset-funded-place-if-set
branch
from
7ad22c1
to
ab34683
Compare
cwrw
reviewed
May 17, 2024
| @@ -33,6 +33,9 @@ def call | |||
| profile.destroy! | |||
| end | |||
| npq_application.update!(lead_provider_approval_status: "pending") | |||
| if FeatureFlag.active?(:npq_capping) && !npq_application.funded_place.nil? | |||
| npq_application.update!(funded_place: false) | |||
There was a problem hiding this comment.
can we please set this to nil not false?
There was a problem hiding this comment.
Addressed in fb5852c
cwrw
approved these changes
May 17, 2024
pmanrubia
deleted the
CPDLP-3071-npq-capping-update-change-to-pending-service-to-unset-funded-place-if-set
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Description
We set a funded place when an application is accepted. If we revert the acceptance we also need to unset the capping change.