Add endpoint to update the funding status #4738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwrw
reviewed
May 9, 2024
mooktakim
force-pushed
the
CPDLP-2938-npq-capping-add-funded-place-to-accept-npq-application-endpoint
branch
3 times, most recently
from
a6ecaac
to
0bb5bbb
Compare
pmanrubia
force-pushed
the
CPDLP-2949-npq-capping-add-new-funded-cap-endpoint
branch
from
a740f46
to
09501bb
Compare
cwrw
reviewed
May 13, 2024
cwrw
reviewed
May 13, 2024
mooktakim
force-pushed
the
CPDLP-2938-npq-capping-add-funded-place-to-accept-npq-application-endpoint
branch
2 times, most recently
from
70d0806
to
cf1aa89
Compare
cwrw
reviewed
May 13, 2024
cwrw
reviewed
May 13, 2024
There was a problem hiding this comment.
thanks pablo for addressing all comments, a few notes from testing:
- we shouldn’t allow setting a value to nil on funded applications
- it currently returns a 500 rather than 422 if application is not accepted
- We'll discuss in person when we're allowed to change which should only be on cohorts that allow capping
pmanrubia
force-pushed
the
CPDLP-2949-npq-capping-add-new-funded-cap-endpoint
branch
from
a32c553
to
081baef
Compare
Addressed in 081baef
Addressed in 35d11e3
Addressed in b41195a |
mooktakim
force-pushed
the
CPDLP-2938-npq-capping-add-funded-place-to-accept-npq-application-endpoint
branch
2 times, most recently
from
6bc9cea
to
9c30630
Compare
Base automatically changed from
CPDLP-2938-npq-capping-add-funded-place-to-accept-npq-application-endpoint
to
main
May 17, 2024 09:22
pmanrubia
force-pushed
the
CPDLP-2949-npq-capping-add-new-funded-cap-endpoint
branch
from
893dfb8
to
11e9d35
Compare
cwrw
reviewed
May 17, 2024
cwrw
reviewed
May 17, 2024
Co-authored-by: Abeer Salameh <cwrw@users.noreply.github.com>
The validations are raising errors otherwise
Co-authored-by: Abeer Salameh <cwrw@users.noreply.github.com>
Co-authored-by: Abeer Salameh <cwrw@users.noreply.github.com>
pmanrubia
force-pushed
the
CPDLP-2949-npq-capping-add-new-funded-cap-endpoint
branch
from
250a754
to
a910a41
Compare
|
Review app deployed to https://cpd-ecf-review-4738-web.test.teacherservices.cloud |
- If there are no statements do not attempt a query for contracts - Fix specs to point to correct cpd lead provider
cwrw
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://dfedigital.atlassian.net/browse/CPDLP-2949
Context
Adds endpoint to change the
funded_placeattribute for an application. It validatesthat the request can be executed within the current application status.