Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1905 - feat(fworks): download frameworks register csv #1813

Merged
merged 1 commit into from
Apr 24, 2024
Merged

1905 - feat(fworks): download frameworks register csv #1813

merged 1 commit into from
Apr 24, 2024

Conversation

serenaabbott11
Copy link
Contributor

Changes in this PR

  • Adds a button on frameworks page to give procops ability to download a csv of the frameworks register
  • Fixes a couple of typos

Screen-shots or screen-capture of UI changes

@serenaabbott11 serenaabbott11 self-assigned this Apr 22, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
26.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@serenaabbott11 serenaabbott11 marked this pull request as ready for review April 23, 2024 16:19
@github-actions GitHub Actions
Copy link

Test coverage

Line: 88.24%
Branch: 78.95%

@serenaabbott11 serenaabbott11 merged commit a6a9dcc into main Apr 24, 2024
32 of 33 checks passed
@serenaabbott11 serenaabbott11 deleted the pwnn-1905-download-framework-csv branch April 24, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cocoaken cocoaken cocoaken approved these changes

@EdwinKruglov EdwinKruglov Awaiting requested review from EdwinKruglov EdwinKruglov is a code owner

Assignees

@serenaabbott11 serenaabbott11

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@serenaabbott11 @cocoaken