Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable strict_args warning in Sidekiq #6471

Closed
wants to merge 1 commit into from
Closed

Conversation

cwrw
Copy link
Contributor

@cwrw cwrw commented Feb 1, 2022

Context

A new warning was introduced in latest Sidekiq: sidekiq/sidekiq#5071 which will become an error in version 7.0.0.

This is raising errors in the following workers:

VendorAPIRequestWorker
DataExporter

I've added the following tickets to address those later:
https://trello.com/c/VDFAN4u0/2274-rework-vendorapirequestworker
https://trello.com/c/ZpGm6nOH/2275-change-dataexporter-to-use-native-json-types

For now disable this warning

Changes proposed in this pull request

Disable Sidekiq warning in the Sidekiq initializer

Guidance to review

Link to Trello card

https://github.com/mperham/sidekiq/pull/5071/files

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • API release notes have been updated if necessary
  • Required environment variables have been updated added to the Azure KeyVault

This will silence the following warning:
Job arguments to #{item["class"]} do not serialize to JSON safely
@cwrw
Copy link
Contributor Author

cwrw commented Mar 14, 2022

closing as going to implement fix rather than ignore

@cwrw cwrw closed this Mar 14, 2022
@elliotcm elliotcm deleted the disable-strict-args branch October 21, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants