New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: design submission form #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small things:
- On the old platform both BiGG and Rhea are ticked when clicking on advanced
- The choice of organism changes the available models in the advance view and if there is only one that one is selcted automatically
You might already be aware of these as this is WIP.
Other than that and my in-line comments this is looking good!
@Midnighter can you please avoid ec7 becoming the default yeast model if you can because it doesn't work. We should integrate the yeast 8 model that has bigg IDs soon. |
I have now completed the design submission form. The mapping started in I'd like to merge this for now since I need to work on the pitch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me except for that one error I'm having that it doesn't show the available models after selecting an Organism and a Project.
I couldn't test the submission process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some concerns about typing that I think should be addressed.
I've also made a handful of comments on both design and technical matters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a few very minor comments left but overall agree and approve!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - I added two comments. I think the model object vs id should be fixed, while the rules issue is not important. Other than that, I still don't approve of us defining types from 3rd party libraries, but I guess I'm in the minority on this.
@kvikshaug I've addressed your comments. I'm not 100% happy with the field validation yet but the hint is a decent solution for now. Not willing to spend any more time on it. I've also removed |
WIP:
Question:
AxiosResponse
type annotation doesn't work. Does anyone know why?