Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try old sphinx-rtd-theme ver: 1.0.0 back to 0.5.2 #144

Merged
merged 2 commits into from
Feb 18, 2022
Merged

Conversation

Condo-Colin
Copy link
Contributor

0.5.2 was the last known good version of sphinx-rtd-theme to work with our menu system.
Using 1.0.0 kills menu icons, and menu is not visible on mobile.
Maybe changing this back in docs.yml might fix the issue!

@Condo-Colin Condo-Colin merged commit fb7c396 into sphinx Feb 18, 2022
@cjmayo
Copy link
Contributor

cjmayo commented Feb 18, 2022

mobile didn't even cross my mind to check...

After looking I can see the top navigation bar problem on mobile, and have reported it.

I don't the icons problem though.

@Condo-Colin
Copy link
Contributor Author

Thanks CJ! That's good.
So is the mobile menu still functional then, but just white/invisible??
The issue with the icons was, the first/last time it happened, the little expand/collapse [+] [--] icons on the desktop page menu also disappeared.

@cjmayo
Copy link
Contributor

cjmayo commented Feb 19, 2022

With the icons I wonder (hope) if this time your browser was caching the old theme.css and it might have been fixed by pressing Ctrl-F5 (or equivalent for forcing a reload of everything).

I'm glad you found and fixed both problems before the 4.0 release!

@Condo-Colin
Copy link
Contributor Author

OK!
No, it was noticed after the release, so hopefully not too many people got lost looking for info.
You should join our Discord so you can be part of our documentation convos about our website formatting questions etc!
Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants