Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bullet formatting due to theme.css #131

Merged
merged 4 commits into from
Feb 15, 2022
Merged

Fix bullet formatting due to theme.css #131

merged 4 commits into from
Feb 15, 2022

Conversation

cjmayo
Copy link
Contributor

@cjmayo cjmayo commented Feb 7, 2022

Remove copy of theme.css

Blocking the installation of theme.css from sphinx-rtd-theme.
Stopping bulleted lists from being correctly displayed.

--

Remove _static/dccex_theme.css
Not used since:
5b4285a ("removed some unncessary extensions ( for now ) / fixed some more typos", 2020-11-23)

--

Use html_css_files to install _static/css/dccex_theme.css

@cjmayo
Copy link
Contributor Author

cjmayo commented Feb 7, 2022

That is fix the bullets with sphinx_rtd_theme 1.0.0. Still don't get the + signs, but not the ugly shapes either.

Blocking the installation of theme.css from sphinx-rtd-theme.
Stopping bulleted lists from being correctly displayed with
sphinx-rtd-theme 1.0.0.
Not used since:
5b4285a ("removed some unncessary extensions ( for now ) / fixed some more typos", 2020-11-23)
@cjmayo
Copy link
Contributor Author

cjmayo commented Feb 8, 2022

+ signs are present. The + signs are added by inline JavaScript and I had my local web server set to add headers to stop inline JavaScript being executed.

I believe this does fix readthedocs/sphinx_rtd_theme#1236 for us (possible there was also another issue causing the ugly shapes - I think I remember something last year, but have forgotten what exactly it was) and make the code compatible with sphinx-rtd-theme 1.0.0. I've added a commit to remove the restriction to 0.5.2.

@cjmayo cjmayo merged commit 67e853e into DCC-EX:sphinx Feb 15, 2022
@cjmayo cjmayo deleted the css branch February 15, 2022 19:58
flash62au added a commit that referenced this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant