Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a11y testing #2946

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Add a11y testing #2946

wants to merge 5 commits into from

Conversation

xmunoz
Copy link
Member

@xmunoz xmunoz commented May 3, 2023

Fixes #1691 .

@xmunoz xmunoz force-pushed the add_a11y_testing branch 2 times, most recently from efde603 to 9d79457 Compare May 4, 2023 14:00
@xmunoz
Copy link
Member Author

xmunoz commented Jun 20, 2023

We're going to take a manual testing approach for now.

@xmunoz xmunoz closed this Jun 20, 2023
@colinxfleming
Copy link
Member

let's keep this open for one more day - want to try something with this as a base

@colinxfleming colinxfleming reopened this Jun 20, 2023
@colinxfleming
Copy link
Member

@xmunoz had a sec to take a pass at this and here's the output - the routing_test (the more straightforward capybara test we have) now has an assert_accessible page in it. (Goofily, since rails 6 or so, integration tests have been more 'post a payload to this endpoint', and system tests have been the 'load up your browser' tests.) Definitely a gotcha, but assert_accessible should cooperate now.

sorry for some of the gemfile regressions. I think probably drop and redo the merge commit there.

@xmunoz
Copy link
Member Author

xmunoz commented Jun 21, 2023

Sweet, thanks!

@xmunoz xmunoz force-pushed the add_a11y_testing branch 6 times, most recently from 943e881 to 1545265 Compare June 22, 2023 15:45
@xmunoz
Copy link
Member Author

xmunoz commented Jun 22, 2023

One of the a11y violations was fixed by upgrading bootstrap_form. Unfortunately, this package upgrade also causes some of the integration tests to fail. There is only one other violation remaining, and the fix looks pretty straight-forward.

Cristina Muñoz and others added 4 commits June 27, 2023 11:56
@xmunoz
Copy link
Member Author

xmunoz commented Jun 27, 2023

After more investigation, I'm not sure how to fix the other a11y concern. It specifically concerns missing table header text for the following scenarios.
header

header2

We are using those header spaces for layout. The elements in these column are icons which are hidden from aria, meaning they are invisible to screen readers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Perform an a11y/WCAG review
2 participants