Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the configuration model #2921

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Nubbify
Copy link

@Nubbify Nubbify commented Apr 13, 2023

What we're doing here is both adding a new dictionary for default values (in anticipation of pre-populating these fields in the new config designs and also because it's a bit cleaner) and also changing the way we do validation so that we return useful error messages in our errors array whenever validation fails.

This pull request makes the following changes:

  • New DEFAULTS dictionary inside of the config model
  • Return validation failure reasons from config controllers

It relates to the following issue #s:

@Nubbify Nubbify force-pushed the oscar/config-validation-messages branch from c793205 to fcfb010 Compare April 13, 2023 00:50
@Nubbify Nubbify marked this pull request as draft April 13, 2023 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant