Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cw-admin-factory contract #370

Merged
merged 3 commits into from Jun 25, 2022
Merged

add cw-admin-factory contract #370

merged 3 commits into from Jun 25, 2022

Conversation

blue-note
Copy link
Contributor

closes #359

@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2022

Codecov Report

Merging #370 (e025f49) into main (a6da405) will increase coverage by 0.01%.
The diff coverage is 98.46%.

@@            Coverage Diff             @@
##             main     #370      +/-   ##
==========================================
+ Coverage   96.92%   96.94%   +0.01%     
==========================================
  Files          37       39       +2     
  Lines        8695     8760      +65     
==========================================
+ Hits         8428     8492      +64     
- Misses        267      268       +1     
Impacted Files Coverage Δ
contracts/cw-admin-factory/src/contract.rs 95.45% <95.45%> (ø)
contracts/cw-admin-factory/src/tests.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6da405...e025f49. Read the comment docs.

Copy link
Contributor

@0xekez 0xekez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! No feedback on the functionality. Would be great to add a test using the mock_env and etc. functions, but not a big deal if you alternatively want to test this on chain and then link to the transaction or something.

contracts/cw-admin-factory/src/msg.rs Outdated Show resolved Hide resolved
@blue-note blue-note changed the title add cw-core-factory contract add cw-admin-factory contract Jun 24, 2022
Copy link
Collaborator

@Callum-A Callum-A left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, shame about multitest but it is what it is. Zeke made some good points to address prior to merge but overall functionality is good!

@0xekez
Copy link
Contributor

0xekez commented Jun 24, 2022

Need to rebase on main for typescript to work.

@blue-note blue-note merged commit 992d201 into main Jun 25, 2022
@blue-note blue-note deleted the jchalam/factory branch June 25, 2022 02:44
JakeHartnell pushed a commit that referenced this pull request Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write factory contract that can instantiate a contract with the contract as its own admin.
4 participants