Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crate type detection #554

Merged
merged 5 commits into from Nov 17, 2023
Merged

Conversation

Shnatsel
Copy link
Contributor

No description provided.

@Shnatsel Shnatsel requested a review from a team as a code owner November 14, 2023 22:26
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
@Shnatsel
Copy link
Contributor Author

Shnatsel commented Nov 16, 2023

PR to update the documentation in the cargo_metadata crate: oli-obk/cargo_metadata#255 These are the docs that misled me in the first place and caused this bug.

PR to add Target.is_proc_macro() to make this code less ugly: oli-obk/cargo_metadata#256

@lfrancke lfrancke merged commit 8e7be4b into CycloneDX:main Nov 17, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants