GT-1064 Update dagger hilt ViewModel support #1515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps `deps.hilt` from 2.30.1-alpha to 2.31.2-alpha. Updates `hilt-android-gradle-plugin` from 2.30.1-alpha to 2.31.2-alpha - [Release notes](https://github.com/google/dagger/releases) - [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md) - [Commits](https://github.com/google/dagger/commits) Updates `hilt-android` from 2.30.1-alpha to 2.31.2-alpha - [Release notes](https://github.com/google/dagger/releases) - [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md) - [Commits](https://github.com/google/dagger/commits) Updates `hilt-compiler` from 2.30.1-alpha to 2.31.2-alpha - [Release notes](https://github.com/google/dagger/releases) - [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md) - [Commits](https://github.com/google/dagger/commits) Updates `hilt-android-testing` from 2.30.1-alpha to 2.31.2-alpha - [Release notes](https://github.com/google/dagger/releases) - [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md) - [Commits](https://github.com/google/dagger/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
frett
force-pushed
the
daggerHiltViewModels
branch
from
3112a82
to
4d5ffe2
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1515 +/- ##
===========================================
- Coverage 26.39% 26.38% -0.02%
===========================================
Files 248 248
Lines 5644 5648 +4
Branches 938 943 +5
===========================================
Hits 1490 1490
- Misses 3853 3857 +4
Partials 301 301
Continue to review full report at Codecov.
|
gyasistory
approved these changes
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to refactor how I was leveraging ViewModels for the tools list adapter due to google/dagger#2328