feat: support browser args #278
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
commented
Apr 14, 2020
NullVoxPopuli
commented
Apr 14, 2020
NullVoxPopuli
force-pushed
the
allow-browser-args-forward
branch
from
cb06cd2
to
1bb2f3b
Compare
|
Resolved the comments since none of the original code from my first pass exists anymore |
NullVoxPopuli
commented
Apr 28, 2020
| @@ -19,6 +20,9 @@ const { defaults } = require('@faltest/utils'); | |||
| // We aren't using `@wdio/cli` (wdio testrunner) | |||
| process.env.SUPPRESS_NO_CONFIG_WARNING = 'true'; | |||
|
|
|||
| let configDir = process.env.FALTEST_CONFIG_DIR || process.cwd(); | |||
|
|
|||
There was a problem hiding this comment.
if interested, I could do another PR for adding prettier
There was a problem hiding this comment.
I wouldn't want this project to have a custom solution. I'd want everything to be in it's own package like https://github.com/CrowdStrike/eslint-config-crowdstrike, then appllied here and in other repos.
NullVoxPopuli
commented
Apr 28, 2020
|
|
||
| let faltestConfig = loadConfig(); | ||
|
|
||
| let argsFromConfig = (((faltestConfig.options || {}).browsers || {})[_browser] || {}).args || []; |
There was a problem hiding this comment.
this is what my .faltestrc.js looks like
'use strict';
module.exports = {
options: {
targets: {
default: 'default',
list: ['default', 'local', 'ember', 'pull-request'],
},
browsers: {
firefox: {
args: [
// TODO
],
},
chrome: {
args: [
'--window-size=1280,720', // 720p
'--ignore-certificate-errors'
].filter(Boolean)
}
}
},
globs: ['tests/**/*-test.js'],
};
kellyselden
reviewed
Jun 21, 2020
| @@ -19,6 +20,9 @@ const { defaults } = require('@faltest/utils'); | |||
| // We aren't using `@wdio/cli` (wdio testrunner) | |||
| process.env.SUPPRESS_NO_CONFIG_WARNING = 'true'; | |||
|
|
|||
| let configDir = process.env.FALTEST_CONFIG_DIR || process.cwd(); | |||
|
|
|||
There was a problem hiding this comment.
I wouldn't want this project to have a custom solution. I'd want everything to be in it's own package like https://github.com/CrowdStrike/eslint-config-crowdstrike, then appllied here and in other repos.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no idea how to test this locally -- I tried linking, but for one minute, the browsers just repeatedly open and close. :-\