Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor daemonset for OpenShift certification requirements #235

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Refactor daemonset for OpenShift certification requirements #235

wants to merge 6 commits into from

Conversation

redhatrises
Copy link
Contributor

No description provided.

@redhatrises redhatrises changed the title Refactor daemonset perms to be generated Refactor daemonset for OpenShift certification requirements May 12, 2022
isimluk
isimluk approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@isimluk isimluk left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit bitter sweet.

I always cheer when code is removed, but come on, this was my code.

@redhatrises redhatrises force-pushed the refactor_node_perms branch 2 times, most recently from 82e2e0e to 1cee94d Compare June 10, 2022 21:47
@redhatrises redhatrises force-pushed the refactor_node_perms branch 2 times, most recently from 293839a to eb0b55b Compare June 22, 2022 19:32
@redhatrises redhatrises force-pushed the refactor_node_perms branch 5 times, most recently from f74aed9 to 7140759 Compare July 18, 2022 19:27
@redhatrises redhatrises marked this pull request as ready for review July 26, 2022 16:33
@redhatrises redhatrises mentioned this pull request Jul 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isimluk isimluk isimluk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@redhatrises @isimluk