Save plugin preferences with expected static key #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
joelamb
force-pushed
the
plugin-preferences-storage-keys
branch
3 times, most recently
from
3673c78
to
f8b207d
Compare
joelamb
changed the title
joelamb
force-pushed
the
plugin-preferences-storage-keys
branch
from
5d661ec
to
9f3d290
Compare
joelamb
force-pushed
the
plugin-preferences-storage-keys
branch
from
9f3d290
to
41f0168
Compare
Plugin preferences should be saved with the key defined in the name property of the class ref: https://ember-headless-table.pages.dev/api/interfaces/plugins.Plugin#name
None of this logic was previously working, because the feature 'columnResizing' that was added in commit: 7a09878 and being used to lookup the plugin was incorrect. Since we were always getting back the table.columns.values, we can revert this unused logic.
joelamb
force-pushed
the
plugin-preferences-storage-keys
branch
from
41f0168
to
9f15bc8
Compare
joelamb
force-pushed
the
plugin-preferences-storage-keys
branch
from
9f15bc8
to
5204d8f
Compare
joelamb
force-pushed
the
plugin-preferences-storage-keys
branch
from
e365298
to
a11e22e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This BREAKING CHANGE fixes issue#238 by correctly using the name property of the plugin class to save preferences.
Updates tests
Why is this a breaking change? Because, any previously saved preferences will no longer work, since the keys they are currently using will not be recognised