Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency expect-type to ^0.19.0 #196

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 11, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
expect-type ^0.14.2 -> ^0.19.0 age adoption passing confidence
expect-type ^0.15.0 -> ^0.19.0 age adoption passing confidence

Release Notes

mmkal/expect-type (expect-type)

v0.19.0

Compare Source

What's Changed

Full Changelog: mmkal/expect-type@0.18.0...0.19.0

v0.18.0

Compare Source

What's Changed

New Contributors

Full Changelog: mmkal/expect-type@v0.17.3...0.18.0

v0.17.3

Compare Source

v0.17.2

Compare Source

Diff(truncated - scroll right!):

test('toEqualTypeOf with tuples', () => {
  const assertion = `expectTypeOf<[[number], [1], []]>().toEqualTypeOf<[[number], [2], []]>()`
  expect(tsErrors(assertion)).toMatchInlineSnapshot(`
-    "test/test.ts:999:999 - error TS2344: Type '[[number], [2], []]' does not satisfy the constraint '{ [x: number]: { [x: number]: number; [iterator]: (() => IterableIterator<1>) | (() => IterableIterator<number>) | (() => IterableIterator<never>); [unscopables]: (() => { copyWithin: boolean; entries: boolean; fill: boolean; find: boolean; findIndex: boolean; keys: boolean; values: boolean; }) | (() => { copyWithin: boolean; entries: boolean; fill: boolean; find: boolean; findIndex: boolean; keys: boolean; values: boolean; }) | (() => { copyWithin: boolean; entries: boolean; fill: boolean; find: boolean; findIndex: boolean; keys: boolean; values: boolean; }); length: 0 | 1; toString:  ... truncated!!!!'.
-      Types of property 'sort' are incompatible.
-        Type '(compareFn?: ((a: [] | [number] | [2], b: [] | [number] | [2]) => number) | undefined) => [[number], [2], []]' is not assignable to type '\\"Expected: function, Actual: function\\"'.
+    "test/test.ts:999:999 - error TS2344: Type '[[number], [2], []]' does not satisfy the constraint '{ 0: { 0: number; }; 1: { 0: \\"Expected: literal number: 2, Actual: literal number: 1\\"; }; 2: {}; }'.
+      The types of '1[0]' are incompatible between these types.
+        Type '2' is not assignable to type '\\"Expected: literal number: 2, Actual: literal number: 1\\"'.
    999 expectTypeOf<[[number], [1], []]>().toEqualTypeOf<[[number], [2], []]>()
                                                          ~~~~~~~~~~~~~~~~~~~"
  `)
})

v0.17.1

Compare Source

  • disallow .not and .branded together cf38918

(this was actually documented in the v0.17.0 release but really it was only pushed here)

v0.17.0

Compare Source

#​16 went in to - hopefully - significantly improve the error messages produce on failing assertions. Here's an example of how vitest's failing tests were improved:

Before:

image

After:

image

Docs copied from the readme about how to interpret these error messages


Error messages

When types don't match, .toEqualTypeOf and .toMatchTypeOf use a special helper type to produce error messages that are as actionable as possible. But there's a bit of an nuance to understanding them. Since the assertions are written "fluently", the failure should be on the "expected" type, not the "actual" type (expect<Actual>().toEqualTypeOf<Expected>()). This means that type errors can be a little confusing - so this library produces a MismatchInfo type to try to make explicit what the expectation is. For example:

expectTypeOf({a: 1}).toEqualTypeOf<{a: string}>()

Is an assertion that will fail, since {a: 1} has type {a: number} and not {a: string}. The error message in this case will read something like this:

test/test.ts:999:999 - error TS2344: Type '{ a: string; }' does not satisfy the constraint '{ a: \\"Expected: string, Actual: number\\"; }'.
  Types of property 'a' are incompatible.
    Type 'string' is not assignable to type '\\"Expected: string, Actual: number\\"'.

999 expectTypeOf({a: 1}).toEqualTypeOf<{a: string}>()

Note that the type constraint reported is a human-readable messaging specifying both the "expected" and "actual" types. Rather than taking the sentence Types of property 'a' are incompatible // Type 'string' is not assignable to type "Expected: string, Actual: number" literally - just look at the property name ('a') and the message: Expected: string, Actual: number. This will tell you what's wrong, in most cases. Extremely complex types will of course be more effort to debug, and may require some experimentation. Please raise an issue if the error messages are actually misleading.

The toBe... methods (like toBeString, toBeNumber, toBeVoid etc.) fail by resolving to a non-callable type when the Actual type under test doesn't match up. For example, the failure for an assertion like expectTypeOf(1).toBeString() will look something like this:

test/test.ts:999:999 - error TS2349: This expression is not callable.
  Type 'ExpectString<number>' has no call signatures.

999 expectTypeOf(1).toBeString()
                    ~~~~~~~~~~

The This expression is not callable part isn't all that helpful - the meaningful error is the next line, Type 'ExpectString<number> has no call signatures. This essentially means you passed a number but asserted it should be a string.

If TypeScript added support for "throw" types these error messagess could be improved. Until then they will take a certain amount of squinting.

Concrete "expected" objects vs typeargs

Error messages for an assertion like this:

expectTypeOf({a: 1}).toEqualTypeOf({a: ''})

Will be less helpful than for an assertion like this:

expectTypeOf({a: 1}).toEqualTypeOf<{a: string}>()

This is because the TypeScript compiler needs to infer the typearg for the .toEqualTypeOf({a: ''}) style, and this library can only mark it as a failure by comparing it against a generic Mismatch type. So, where possible, use a typearg rather than a concrete type for .toEqualTypeOf and toMatchTypeOf. If it's much more convenient to compare two concrete types, you can use typeof:

const one = valueFromFunctionOne({some: {complex: inputs}})
const two = valueFromFunctionTwo({some: {other: inputs}})

expectTypeOf(one).toEqualTypeof<typeof two>()

Kinda-breaking changes: essentially none, but technically, .branded no longer returns a "full" ExpectTypeOf instance at compile-time. Previously you could do this:

expectTypeOf<{a: {b: 1} & {c: 1}}>().branded.not.toEqualTypeOf<{a: {b: 1; c: ''}}>()
expectTypeOf<{a: {b: 1} & {c: 1}}>().not.branded.toEqualTypeOf<{a: {b: 1; c: ''}}>()

Now that won't work (and it was always slightly nonsensical), so you'd have to use // @&#8203;ts-expect-error instead of not if you have a negated case where you need branded:

// @&#8203;ts-expect-error
expectTypeOf<{a: {b: 1} & {c: 1}}>().branded.not.toEqualTypeOf<{a: {b: 1; c: ''}}>()

What's Changed

New Contributors

Full Changelog: mmkal/expect-type@v0.16.0...v0.17.0

v0.16.0

Compare Source

What's Changed

Note that #​21 has affected behavior for intersection types, which can result in (arguably) false errors:

// @&#8203;ts-expect-error the following line doesn't compile, even though the types are arguably the same.
// See https://github.com/mmkal/expect-type/pull/21
expectTypeOf<{a: 1} & {b: 2}>().toEqualTypeOf<{a: 1; b: 2}>()

Full Changelog: mmkal/expect-type@v0.15.0...v16.0.0

v0.15.0

Compare Source

What's Changed

New Contributors

Full Changelog: mmkal/expect-type@v0.14.2...v0.15.0


Configuration

📅 Schedule: Branch creation - "after 9pm on sunday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@changeset-bot
Copy link

changeset-bot bot commented Jun 11, 2023

⚠️ No Changeset found

Latest commit: 0d9f3e7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@renovate renovate bot force-pushed the renovate/expect-type-0.x branch 11 times, most recently from b13be73 to afecfa5 Compare July 3, 2023 00:15
@renovate renovate bot force-pushed the renovate/expect-type-0.x branch 4 times, most recently from 8710b76 to 263f20f Compare July 10, 2023 04:22
@renovate renovate bot force-pushed the renovate/expect-type-0.x branch from 263f20f to dde5a65 Compare July 17, 2023 01:36
@renovate renovate bot force-pushed the renovate/expect-type-0.x branch 3 times, most recently from a20275d to 322f68d Compare July 31, 2023 00:06
@renovate renovate bot force-pushed the renovate/expect-type-0.x branch 2 times, most recently from 952862e to 8a2ca80 Compare August 7, 2023 01:42
@renovate renovate bot force-pushed the renovate/expect-type-0.x branch 5 times, most recently from 1c06d6b to e8dfe22 Compare August 14, 2023 03:53
@renovate renovate bot force-pushed the renovate/expect-type-0.x branch from e8dfe22 to 21347f2 Compare August 21, 2023 01:06
@renovate renovate bot force-pushed the renovate/expect-type-0.x branch 4 times, most recently from cbc78e4 to d3b4fa6 Compare February 26, 2024 01:19
@renovate renovate bot force-pushed the renovate/expect-type-0.x branch 2 times, most recently from b716de3 to d356a29 Compare February 26, 2024 22:11
@renovate renovate bot changed the title chore(deps): update dependency expect-type to ^0.17.0 chore(deps): update dependency expect-type to ^0.18.0 Feb 26, 2024
@renovate renovate bot force-pushed the renovate/expect-type-0.x branch 2 times, most recently from 44dcdb5 to cb1c0ea Compare March 4, 2024 03:07
@renovate renovate bot force-pushed the renovate/expect-type-0.x branch 3 times, most recently from eed1f99 to c9adc5e Compare March 18, 2024 01:31
@renovate renovate bot force-pushed the renovate/expect-type-0.x branch 2 times, most recently from 28f82f6 to cbb2d5a Compare March 21, 2024 21:29
@renovate renovate bot changed the title chore(deps): update dependency expect-type to ^0.18.0 chore(deps): update dependency expect-type to ^0.19.0 Mar 21, 2024
@renovate renovate bot force-pushed the renovate/expect-type-0.x branch 3 times, most recently from 4a44f3c to 55cf084 Compare April 1, 2024 01:05
@renovate renovate bot force-pushed the renovate/expect-type-0.x branch 2 times, most recently from 2032a6e to edbba3a Compare April 8, 2024 00:48
@renovate renovate bot force-pushed the renovate/expect-type-0.x branch 3 times, most recently from eb3993a to a98723b Compare April 15, 2024 04:46
@renovate renovate bot force-pushed the renovate/expect-type-0.x branch 2 times, most recently from 1030364 to 9d3a153 Compare April 29, 2024 01:28
@renovate renovate bot force-pushed the renovate/expect-type-0.x branch 2 times, most recently from 3cfbe68 to 7815137 Compare May 13, 2024 00:39
@renovate renovate bot force-pushed the renovate/expect-type-0.x branch from 7815137 to 1b96b44 Compare May 27, 2024 00:44
@renovate renovate bot force-pushed the renovate/expect-type-0.x branch from 1b96b44 to 0d9f3e7 Compare June 3, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants