Merge pull request #3 from CovEducation/mi-yu/lint-ci

Run lint in CI step

.travis.yml

@@ -11,6 +11,7 @@ jobs:
       script:
         - npx lerna run --scope coved-server test
         - npx lerna run --scope coved-client test
+        - npx lerna run lint
     - stage: publish
       if: branch = master
       script:

packages/client/package.json

@@ -14,10 +14,21 @@
     "start": "react-scripts start",
     "build": "npx react-scripts build",
     "test": "npx react-scripts test --watchAll=false",
-    "eject": "react-scripts eject"
+    "eject": "react-scripts eject",
+    "lint": "npx eslint src/**/*.js"
   },
   "eslintConfig": {
-    "extends": "react-app"
+    "extends": "react-app",
+    "rules": {
+      "quotes": [
+        "error",
+        "single"
+      ],
+      "object-curly-spacing": [
+        "error",
+        "always"
+      ]
+    }
   },
   "proxy": "http://localhost:8080",
   "browserslist": {
@@ -32,4 +43,4 @@
       "last 1 safari version"
     ]
   }
-}
+}

packages/client/src/App.js

@@ -3,14 +3,13 @@ import logo from './logo.svg';
 import './App.css';
 
 function App() {
-
   var [apiStatus, setApiStatus] = useState(null);
 
   useEffect(() => {
-    fetch("/heartbeat")
-      .then(res => res.text())
-      .then(data => setApiStatus(data))
-      .catch(err => console.log(err));
+    fetch('/heartbeat')
+      .then((res) => res.text())
+      .then((data) => setApiStatus(data))
+      .catch((err) => console.log(err));
   }, []);
 
   return (
@@ -28,7 +27,7 @@ function App() {
         >
           Learn React
         </a>
-        { apiStatus }
+        {apiStatus}
       </header>
     </div>
   );

packages/server/.eslintrc.js

@@ -4,13 +4,11 @@ module.exports = {
     commonjs: true,
     es2020: true,
     node: true,
+    jest: true,
   },
-  extends: [
-    'airbnb-base',
-  ],
+  extends: ['airbnb-base'],
   parserOptions: {
     ecmaVersion: 11,
   },
-  rules: {
-  },
+  rules: {},
 };

packages/server/app.js

@@ -9,8 +9,8 @@ const usersRouter = require('./routes/users');
 const app = express();
 
 // disable logging when running unit tests
-if (process.env.NODE_ENV !== "test") {
-    app.use(logger('dev'));
+if (process.env.NODE_ENV !== 'test') {
+  app.use(logger('dev'));
 }
 
 app.use(express.json());