fix(course duplication): fix logo not duplicated due to carrierwave upgrade #4179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekowidianto
force-pushed
the
eko/fix-logo-duplication-issue
branch
from
c32fefb
to
174c92e
Compare
zhuhanming
approved these changes
Nov 18, 2021
|
Can we also extend this to achievement badge duplication? |
|
This won't affect the achievement badge duplication since there is no reload done on the duplicated achivement object. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4167 and #3677
As per carrierwave v2.1.0, carrierwave image mounter that retains uploaded file as a cache is reset upon reload (in our case it is new_course.reload) which then causes course logo to be unduplicated
carrierwaveuploader/carrierwave#2482 (comment)