#239: bug/firestore_native_mode - in deploy, ensuring firestore database is configured in native mode #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gured in native mode
|
I will run a quick deploy test in ~30 minutes! |
|
I think the issue causing failures here is a simple missing dependency that spacy added in the last few months. When I try my deploy I will try and fix |
|
@gregoryfoster can you pull and merge main? I just pushed a commit that should fixed the pipeline |
|
Actually I am going to close this as I tested out your change and it was almost correct but had to move some stuff around and add a sleep statement. All of the changes were pushed here: Thanks for finding the correct command to use because finding the right spot was a breeze |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Relevant Issue
This pull request resolves #239
Description of Changes
Adds call to:
gcloud alpha firestore databases update --type=firestore-nativein the
deployworkflow in theJustfile. Has not been tested! And might be better situated more immediately after the creation of the firestore database in thesetupworkflow. But I just placed it in the location identified in the related issue as when the issue arises, so it should be fine as is.