Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some image files store in firebase storage don't have the correct content #192

Open
tohuynh opened this issue Jun 13, 2022 · 0 comments
Open
Labels
bug Something isn't working

Comments

@tohuynh
Copy link
Collaborator

tohuynh commented Jun 13, 2022

Describe the Bug

A clear and concise description of the bug.
Some images (such as person pictures or seat pictures) stored in firebase storage don't have the same content as their sources.

My guess is that cdp-backend tries to download the image content from one of the URIs in the JSON file and when it fails the failed content was uploaded to firebase storage instead of the image content.

I think the solution here is to make sure the step to download the image is successful?

Expected Behavior

What did you expect to happen instead?
Image content stored in firebase storage should be the same as the original images.

Reproduction

Steps to reproduce the behavior and/or a minimal example that exhibits the behavior.
image

This is the actual content of the above firebase storage URI (it doesn't look like it could be an image file):
image

Environment

Any additional information about your environment.

  • OS Version: [e.g. macOS 11.3.1]
  • CDP Backend Version: [e.g. 0.5.0]

cc @JacksonMaxfield @dphoria

@tohuynh tohuynh added the bug Something isn't working label Jun 13, 2022
@tohuynh tohuynh changed the title Some image files store in firebase storage don't the correct content Some image files store in firebase storage don't have the correct content Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant