Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better method for finding/creating context span of an IndexedEventGram (in event index pipeline) #143

Open
tohuynh opened this issue Dec 17, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@tohuynh
Copy link
Collaborator

tohuynh commented Dec 17, 2021

Describe the Bug

IndexedEventGram's context_span provides a surrounding context of the gram. The current method to find/create the context span is not ideal. Sometimes context span doesn't entirely contain the gram.

Expected Behavior

The context span should contain the gram in its entirety.

In the intermediary step of creating n grams, keep track of the gram's start index (and maybe end index) in the original sentence so that a context span could be created from these indices.

@tohuynh tohuynh added the bug Something isn't working label Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant