Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create 2024-04-21 #4229

Merged
merged 2 commits into from
May 26, 2024
Merged

Create 2024-04-21 #4229

merged 2 commits into from
May 26, 2024

Conversation

bakeiro
Copy link
Contributor

@bakeiro bakeiro commented Apr 21, 2024

Backend checklist

  • Formatted my code by running autoflake --exclude src/proto -r -i --remove-all-unused-imports src && isort . && black . in app/backend
  • Added tests for any new code or added a regression test if fixing a bug
  • All tests pass
  • Run the backend locally and it works
  • Added migrations if there are any database changes, rebased onto develop if necessary for linear migration history

Web frontend checklist

  • Formatted my code with make format
  • There are no warnings from make lint
  • There are no console warnings when running the app
  • Added any new components to storybook
  • Added tests where relevant
  • All tests pass
  • Clicked around my changes running locally and it works
  • Checked Desktop, Mobile and Tablet screen sizes

@aapeliv aapeliv merged commit 1416d14 into develop May 26, 2024
@aapeliv aapeliv deleted the bakeiro-patch-1 branch May 26, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aapeliv aapeliv aapeliv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bakeiro @aapeliv