Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked notifications, notify for events #4044

Merged
merged 18 commits into from
May 19, 2024

Conversation

aapeliv
Copy link
Member

@aapeliv aapeliv commented Apr 11, 2024

Backend checklist

  • Formatted my code by running autoflake -r -i --remove-all-unused-imports src && isort . && black . in app/backend
  • Added tests for any new code or added a regression test if fixing a bug
  • All tests pass
  • Run the backend locally and it works
  • Added migrations if there are any database changes, rebased onto develop if necessary for linear migration history

@aapeliv aapeliv self-assigned this Apr 11, 2024
@aapeliv aapeliv force-pushed the backend/feature/event-notifications branch 5 times, most recently from 1334938 to c2d66b2 Compare April 14, 2024 19:09
@aapeliv aapeliv added backend This issue relates to the python backend release notes: pending Add to stuff that should be included in release notes labels Apr 18, 2024
@aapeliv aapeliv force-pushed the backend/feature/event-notifications branch 2 times, most recently from 9e91fe7 to f85a0e9 Compare April 24, 2024 15:45
@aapeliv aapeliv force-pushed the backend/feature/event-notifications branch from f85a0e9 to 3d1820d Compare May 3, 2024 19:02
@aapeliv aapeliv marked this pull request as ready for review May 3, 2024 19:15
@aapeliv aapeliv requested a review from spreeni May 3, 2024 19:15
@aapeliv
Copy link
Member Author

aapeliv commented May 3, 2024

This only applies to those with new notifications enabled, so it should be fine to merge.

@aapeliv
Copy link
Member Author

aapeliv commented May 4, 2024

These are the defaults:

Screenshot from 2024-05-03 21-22-17

@aapeliv
Copy link
Member Author

aapeliv commented May 4, 2024

Critical parts left:

  • test for event notifs
  • adjust digest frequency/disable it

@aapeliv aapeliv force-pushed the backend/feature/event-notifications branch from e4a0114 to 84c0297 Compare May 19, 2024 22:18
@aapeliv aapeliv merged commit 4db1721 into develop May 19, 2024
1 check was pending
@aapeliv aapeliv deleted the backend/feature/event-notifications branch May 19, 2024 23:22
@schradert schradert added feature Implementation of a feature labels May 23, 2024
@schradert schradert modified the milestone: V1 May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend This issue relates to the python backend feature Implementation of a feature release notes: pending Add to stuff that should be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants