Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize spec events #845

Merged
merged 1 commit into from Nov 25, 2022
Merged

Standardize spec events #845

merged 1 commit into from Nov 25, 2022

Conversation

uint
Copy link
Contributor

@uint uint commented Nov 23, 2022 •
edited

Closes #823

Just setting the event attributes in stone so that the APIs are clear

ethanfrey
ethanfrey approved these changes Nov 24, 2022
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition. Thanks

@uint uint merged commit 7949844 into main Nov 25, 2022
@uint uint deleted the standardize-events branch November 25, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey ethanfrey approved these changes

@webmaster128 webmaster128 Awaiting requested review from webmaster128

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Standardize protocol events
2 participants
@uint @ethanfrey