Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cw1155-base public queries and move tests #804

Merged
merged 4 commits into from Sep 27, 2022
Merged

Cw1155-base public queries and move tests #804

merged 4 commits into from Sep 27, 2022

Conversation

ismellike
Copy link
Contributor

Added query methods for all cw1155 queries and made them public

Also moved out tests to their own module

@ismellike ismellike changed the title Use public queries and move tests Cw1155 public queries and move tests Sep 20, 2022
@ismellike ismellike changed the title Cw1155 public queries and move tests Cw1155-base public queries and move tests Sep 20, 2022
uint
uint approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@uint uint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the idea with moving tests to a separate module is that they really test the whole contract and they're not just "contract module tests"? Makes sense.

Thanks for pulling these queries into separate functions! Good change. Happy to merge.

@uint
Copy link
Contributor

uint commented Sep 27, 2022

Nice! Thanks a lot for this.

@uint uint merged commit c53df3f into CosmWasm:main Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uint uint uint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ismellike @uint