Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove backtraces feature #1967

Merged
merged 14 commits into from
Nov 30, 2023
Merged

Remove backtraces feature #1967

merged 14 commits into from
Nov 30, 2023

Conversation

chipshort
Copy link
Collaborator

closes #1760

We cannot use the #[from] annotation anymore, so I added an internal macro for that (currently we only use it for one variant).

webmaster128
webmaster128 reviewed Nov 28, 2023
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff. Now this delegates everything to Backtrace::capture() and the Box<Backtrace> is always set. It would be nice to have an example that shows the flexibility. Why did we need that again? Just no_std or the wasm32 target as well?

packages/std/src/errors/backtrace.rs Outdated Show resolved Hide resolved
packages/std/src/lib.rs Show resolved Hide resolved
packages/std/src/errors/backtrace.rs Outdated Show resolved Hide resolved
packages/vm/src/errors/backtrace.rs Show resolved Hide resolved
webmaster128
webmaster128 approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks. Then just CHANGELOG and MIGRATING left here

@chipshort chipshort merged commit 04a0e52 into main Nov 30, 2023
24 of 27 checks passed
@chipshort chipshort deleted the 1760-remove-backtrace-feature branch November 30, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider removing feature-gating of backtraces in 2.0
2 participants
@chipshort @webmaster128