Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPStan for WordPress 1.1.5 compatbility #385

Merged
merged 2 commits into from Nov 15, 2022
Merged

PHPStan for WordPress 1.1.5 compatbility #385

merged 2 commits into from Nov 15, 2022

Conversation

n7studios
Copy link
Contributor

@n7studios n7studios commented Nov 11, 2022 •
edited

Summary

Fixes failing static analysis tests due to improvements in static analysis in PHPStan for WordPress 1.1.5.

Testing

Existing tests pass.

Checklist

@n7studios n7studios self-assigned this Nov 11, 2022
@n7studios n7studios requested review from a team, noelherrick and corydhmiller and removed request for a team November 14, 2022 12:24
@n7studios n7studios marked this pull request as ready for review November 14, 2022 12:24
@n7studios n7studios marked this pull request as draft November 14, 2022 12:57
@n7studios n7studios changed the title PHPStan for WordPress 1.1.4 compatbility PHPStan for WordPress 1.1.5 compatbility Nov 14, 2022
@n7studios n7studios marked this pull request as ready for review November 14, 2022 13:33
corydhmiller
corydhmiller approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@corydhmiller corydhmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep good to go

@n7studios n7studios merged commit 87c327c into main Nov 15, 2022
@n7studios n7studios deleted the phpstan-wordpress-1.1.4 branch December 15, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corydhmiller corydhmiller corydhmiller approved these changes

@noelherrick noelherrick Awaiting requested review from noelherrick noelherrick was automatically assigned from ConvertKit/wordpress

Assignees

@n7studios n7studios

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@n7studios @corydhmiller