Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DP-2579] Upgrade ih-setup pre-commit #56

Merged
merged 2 commits into from Jun 16, 2023

Conversation

chriscerk
Copy link
Contributor

@chriscerk chriscerk commented Jun 16, 2023

Problem

When using pre-commit 2.15.0, it lacks a very helpful error message when
python hooks are incompatible with the python environment being used.

Proposal

Upgrade pre-commit in /lib/core/asdf/.tool-versions from 2.15.0 to 3.2.2

Impact

  • engineers can more easily debug python hook issues

@chriscerk chriscerk marked this pull request as ready for review June 16, 2023 15:31
@chriscerk chriscerk requested a review from a team as a code owner June 16, 2023 15:31
@joemccall86
Copy link
Contributor

Are we affected by the breaking changes between pre-commit 2 -> 3?

@chriscerk
Copy link
Contributor Author

Are we affected by the breaking changes between pre-commit 2 -> 3?

Good call @joemccall86 💯

Overall, this will just cause pre-commit to be installed as 3.2.2 for newly joining engineers
(or if someone runs the setup script again)

I've been running 3.2.2 for awhile, but did some digging to make sure this wouldn't cause issues with other ConsultingMD repos.

Below features + updates with @ IH: responses.

⭐ all changes to 3.0 appear to not have any breaking impact on us


Features

Updates


Copy link
Contributor

@joemccall86 joemccall86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool beans, thank you for taking a look

@chriscerk chriscerk merged commit 5edab91 into master Jun 16, 2023
@chriscerk chriscerk deleted the tech-debt/DP-2579/upgrade-ih-setup-pre-commit branch June 16, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants