Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update jetty #1463

Merged
merged 2 commits into from Jun 22, 2022
Merged

update jetty #1463

merged 2 commits into from Jun 22, 2022

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Jun 9, 2022

Signed-off-by: Sally MacFarlane sally.macfarlane@consensys.net

Update jetty to 11.0.10

From Jetty 11.0.10 releases notes, they added this PR 8165 to fix this issue.
They changed how input and output buffers are released.

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
mark-terry
mark-terry previously approved these changes Jun 9, 2022
Copy link
Contributor

@mark-terry mark-terry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

usmansaleem
usmansaleem previously approved these changes Jun 10, 2022
Copy link
Contributor

@usmansaleem usmansaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@macfarla macfarla dismissed stale reviews from usmansaleem and mark-terry via faea08d June 22, 2022 03:22
@macfarla macfarla changed the title update jetty and tuweni update jetty Jun 22, 2022
Copy link
Contributor

@pinges pinges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pinges pinges merged commit 18cb1fc into Consensys:master Jun 22, 2022
@macfarla macfarla deleted the uprevs branch June 22, 2022 08:27
@macfarla macfarla added the 22.1.4 label Jul 2, 2022
@@ -11,7 +11,7 @@ plugins {
}

ext {
jettyVersion = "11.0.8"
jettyVersion = "11.0.10"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would recommend using 11.0.11 as it contains an important fix for suffix based url-patterns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve SSLConnection buffers handling (CVE-2022-2191)
5 participants