Editor! #58
Closed
Editor! #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, we have cases where selecting nodes with no children results in an ambiguous offset. Technically, these represent annotation boundaries, but since we don't actually want to disambiguate these, we're instead looking at pure textual offsets. The major change here was simplifying the code that handles selection on nodes with no children (cf, <hr>, <img>) and nodes that are outside the text selection component.
…have lost the original DOM tree / selection
…(deletion/update of annotations TK)
Specifically, we have cases where selecting nodes with no children results in an ambiguous offset. Technically, these represent annotation boundaries, but since we don't actually want to disambiguate these, we're instead looking at pure textual offsets. The major change here was simplifying the code that handles selection on nodes with no children (cf, <hr>, <img>) and nodes that are outside the text selection component.
…have lost the original DOM tree / selection
…(deletion/update of annotations TK)
added 6 commits
August 3, 2018 15:08
…th local failures
foobarrio
reviewed
Aug 6, 2018
| } | ||
|
|
||
| onSave(evt: Event) { | ||
| let textColor = this.shadowRoot.querySelector('.text-color'); |
There was a problem hiding this comment.
@blaine Should this be grabbing the corresponding attribute instead of querying for the element?
this.getAttribute('text-color')
There was a problem hiding this comment.
The color picker is pretty primitive, so it uses <input type=color> and this is just getting the element to propagate it up, using element.value to fetch the actual color value.
added 8 commits
August 6, 2018 18:50
foobarrio
reviewed
Aug 7, 2018
| @@ -6,7 +6,7 @@ | |||
| "module": "dist/modules/index.js", | |||
| "types": "dist/commonjs/index.d.ts", | |||
| "scripts": { | |||
| "build": "rm -rf dist; tsc -p . && tsc -p . --module ESNext --outDir dist/modules/ --target ES2017", | |||
| "build": "rm -rf dist; tsc -p . ; tsc -p . --module ESNext --outDir dist/modules/ --target ES2017; exit 0", | |||
There was a problem hiding this comment.
This comment is about updating "@atjson/document": "0.8.4" to 0.8.5
foobarrio
reviewed
Aug 7, 2018
| @@ -6,7 +6,7 @@ | |||
| "module": "dist/modules/index.js", | |||
| "types": "dist/commonjs/index.d.ts", | |||
| "scripts": { | |||
| "build": "rm -rf dist; tsc -p . && tsc -p . --module ESNext --outDir dist/modules/ --target ES2017", | |||
| "build": "rm -rf dist; tsc -p . ; tsc -p . --module ESNext --outDir dist/modules/ --target ES2017; exit 0", | |||
There was a problem hiding this comment.
This comment is about updating "@atjson/document": "0.8.4" to 0.8.5
|
@blaine / @foobarrio this gist should help with a bunch of the TypeScript errors in the component: |
This sets a TypeScript compilation context for ts files in test/ allowing VSCode (among other editors) to surface TypeScript errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.