Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-apply TArgs to CSF render type #43

Merged
merged 20 commits into from
Oct 22, 2022

Conversation

tmeasday
Copy link
Contributor

@tmeasday tmeasday commented Apr 12, 2022

For #41

Fix issue where render() has Args as type for first argument.

📦 Published PR as canary version: 0.0.2--canary.43.5edcaf6.0

✨ Test out this PR locally via:

npm install @storybook/csf@0.0.2--canary.43.5edcaf6.0
# or 
yarn add @storybook/csf@0.0.2--canary.43.5edcaf6.0

Copy link
Contributor

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@IanVS IanVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@IanVS
Copy link

IanVS commented Apr 26, 2022

Hi, just a friendly ping! I'd really love to try out the 6.5.0 beta in my app at work, but so far I'm blocked on this.

tmeasday added a commit to storybookjs/storybook that referenced this pull request Apr 27, 2022
@shilman shilman merged commit 5edcaf6 into feat/conditional-args Oct 22, 2022
@shilman shilman deleted the 41-tighten-render-type branch October 22, 2022 08:39
@shilman
Copy link
Contributor

shilman commented Apr 3, 2023

🚀 PR was released in v0.1.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants