Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/plugin issues #3

Merged
merged 7 commits into from
Jun 23, 2022
Merged

Fix/plugin issues #3

merged 7 commits into from
Jun 23, 2022

Conversation

CombeeMike
Copy link
Contributor

@CombeeMike CombeeMike commented Jun 22, 2022

The Tailwind & import order plugin have not been working correctly when installed together.
FAL found a workaround which registers the plugins in a different way.
I therefore changed our shared config now to also ship the Tailwind plugin directly.

Once you've approved this change, I'll publish a new final version and will directly commit the version update to the react-app repo in the UI improvements branch without an PR as this is pretty minor.

and add workaround to make Tailwind & import plugin work together

#CB-7478
to allow usage in consuming projects

#CB-7478
Copy link

@HoferMarkus HoferMarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it running with the help from Tobias 👍
The plugins property needs to be removed from the .prettierrc.js file in the CBN repository.

Copy link

@cbn-falias cbn-falias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CombeeMike CombeeMike merged commit 6fb0039 into main Jun 23, 2022
@CombeeMike CombeeMike deleted the fix/plugin-issues branch June 23, 2022 14:15
@CombeeMike
Copy link
Contributor Author

FYI, I just published the final version 0.0.3 and updated the react app as well (see this commit, which also includes the removal of above mentioned plugins in .prettierrc.js).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants