Allow installing on PHP 8 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related: Codeception/Codeception#6032 |
Timyipstudio
approved these changes
Dec 16, 2020
|
@Timyipstudio can't merge yet because Codeception itself is not ready. |
Naktibalda
force-pushed
the
php8
branch
2 times, most recently
from
b58e325
to
9201b11
Compare
|
This pull request depends on Codeception/Codeception#6057 being merged. Also I had to change |
samdark
commented
Dec 20, 2020
.github/workflows/main.yml
Outdated
| @@ -37,7 +37,7 @@ jobs: | |||
| run: | | |||
| composer require --no-update codeception/module-asserts | |||
| composer require --no-update codeception/module-filesystem | |||
| composer require --no-update codeception/codeception | |||
| composer require --no-update "codeception/codeception:dev-gherkin-fix-namespaced-contexts as 4.9.9" | |||
There was a problem hiding this comment.
Should be changed before merge.
|
Awesome! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #17