Differentiate parsing errors in a parent class from the ones in the test class #6684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New tests have been added, but I was unable to run them with reasonable effort. If they fail, please help me adjusting them as I've already spent way to much time on this little fix ... :-) Thank you! |
Naktibalda
reviewed
Aug 16, 2023
martin-rueegg
force-pushed
the
fix/parse-exception
branch
from
208202d
to
6054f56
Compare
martin-rueegg
force-pushed
the
fix/parse-exception
branch
from
6054f56
to
168f899
Compare
|
@Naktibalda fixed some more errors based on the test result. Would you mind re-queuing the current version for an automatic test, please? |
martin-rueegg
force-pushed
the
fix/parse-exception
branch
2 times, most recently
from
0a22530
to
9e54a33
Compare
|
Thank you, @Naktibalda Apparently, |
martin-rueegg
force-pushed
the
fix/parse-exception
branch
3 times, most recently
from
d33674b
to
bffedd5
Compare
|
@Naktibalda I'm so sorry, I thought I had tested if null input works ... |
martin-rueegg
force-pushed
the
fix/parse-exception
branch
from
bffedd5
to
bf54a50
Compare
|
@Naktibalda Thanks, I guess we're getting there eventually ... :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a test inherits from a parent class, and there is a parsing error happening while parsing this parent class, then the error shows the parse error and line number from the parent class, but the file name from the (child) test class.
This patch will show the file name in which the error actually happens. And if it's not in the test class it self, it will additionally indicate to the name of the test class.