Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing of skip annotation #6596

Merged
merged 1 commit into from Oct 30, 2022
Merged

Fix parsing of skip annotation #6596

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Codeception/Test/Metadata.php
View file
Open in desktop
Expand Up @@ -200,7 +200,11 @@ public function setParamsFromAnnotations($annotations): void

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that after array_merge_recursive, $this->params['skip'] contains array [null, 'message']

// set singular value for some params
foreach (['skip', 'incomplete'] as $single) {
$this->params[$single] = empty($this->params[$single]) ? null : (string)$this->params[$single][0];
if (empty($this->params[$single])) {
$this->params[$single] = null;
} else {
$this->params[$single] = (string)($this->params[$single][0] ?? $this->params[$single][1]);
}
}
}

Expand Down