Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch Group Creation with Wildcard #6300

Closed
wants to merge 3 commits into from
Closed

Patch Group Creation with Wildcard #6300

wants to merge 3 commits into from

Conversation

DanielHansmannAldi
Copy link

Patch Group Creation with Wildcard to realy work with Filename and not only iterate $i

@DanielHansmannAldi
Patch Group Creation with Wildcard
ec066f3 
Patch Group Creation with Wildcard to realy work with Filename and not only iterate $i
@Naktibalda
Copy link
Member

What problem does it solve?

Please add test to https://github.com/Codeception/Codeception/blob/4.1/tests/unit/Codeception/Lib/GroupManagerTest.php or another relevant test file.

@DavertMik
Copy link
Member

Thanks, @Naktibalda
This concerns a setup in parallelization I will review it and make a release with this patch.

@DavertMik DavertMik mentioned this pull request Dec 21, 2021
Merged
@DavertMik
Copy link
Member

Thanks, @DanielHansmannAldi
I improved the implementation, see #6302

@DavertMik DavertMik closed this Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nitpick-CI Nitpick-CI Nitpick-CI left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DanielHansmannAldi @Naktibalda @DavertMik @Nitpick-CI