Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate use statements based on docblock contents #6267

Open
wants to merge 3 commits into
base: 4.1
Choose a base branch
from

Conversation

DBX12
Copy link

@DBX12 DBX12 commented Oct 18, 2021

Pull request for issue #6266

@DBX12
Copy link
Author

DBX12 commented Oct 20, 2021

Hi @Naktibalda,
sorry for directly tagging you, but could you approve running the workflows? Thank you :)


I'm participating in hacktoberfest, so I would be very happy if you could either mark the PR with an hacktoberfest-accepted label, approve it or merge it before 31st 2021 if you deem it useful :) If you don't think it is helpful, let me know and I withdraw the PR.

@DBX12
Copy link
Author

DBX12 commented Oct 25, 2021

Those dependencies are really ... fun. What is your opinion, should I / we write the annotation parsing from scratch and remove the other package or try to make it work somehow?

@Naktibalda
Copy link
Member

It seems that I took 2 month break, I'm sorry if you didn't get Hacktoberfest T-shirt because of me.

Regarding phpdocumentor/reflection-docblock dependency, if you want to target Codeception 4.1, your code must be compatible with phpdocumentor/reflection-docblock v3 - v5. Probably it would be simpler to target Codeception 5.

And please add test for proposed change to https://github.com/Codeception/Codeception/blob/4.1/tests/cli/BuildCest.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants