Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding clickable editorUrl from codeception.yml #6261

Merged
merged 13 commits into from Dec 21, 2021
Merged

Adding clickable editorUrl from codeception.yml #6261

Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
4dd4839
Adding clickable `editorUrl` from `codeception.yml`
ThomasLandauer Oct 8, 2021
4334050
Update Console.php
ThomasLandauer Oct 8, 2021
1ff4bf8
Update Console.php
ThomasLandauer Oct 8, 2021
20aeddb
Update Console.php
ThomasLandauer Oct 8, 2021
27043fd
Update Step.php
ThomasLandauer Oct 24, 2021
f15b2b8
Update Console.php
ThomasLandauer Oct 24, 2021
a0db625
Update Console.php
ThomasLandauer Dec 11, 2021
a237b5b
Update Console.php
ThomasLandauer Dec 11, 2021
ee62ccd
Update Console.php
ThomasLandauer Dec 11, 2021
0ad2d23
Update Console.php
ThomasLandauer Dec 11, 2021
c73df3d
Update Console.php
ThomasLandauer Dec 11, 2021
3923c44
Update Console.php
ThomasLandauer Dec 11, 2021
2d1ef52
Bringing back but `@deprecate`ing `getLine()`
ThomasLandauer Dec 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 16 additions & 1 deletion src/Codeception/Subscriber/Console.php
View file
Open in desktop
Expand Up @@ -356,8 +356,23 @@ public function printFail(FailEvent $e)
$this->output->write($e->getCount() . ") ");
$this->writeCurrentTest($failedTest, false);
$this->output->writeln('');

// Clickable `editorUrl`:
if (isset($this->options['editorUrl']) and is_string($this->options['editorUrl'])) {
ThomasLandauer marked this conversation as resolved.
Show resolved Hide resolved
$filePath = codecept_absolute_path(Descriptor::getTestFileName($failedTest));
$message = str_replace('%%file%%', $filePath, $this->options['editorUrl']);
ThomasLandauer marked this conversation as resolved.
Show resolved Hide resolved
$line = 1;
foreach ($fail->getTrace() as $trace) {
if (isset($trace['file']) and $filePath === $trace['file'] and isset($trace['line'])) {
ThomasLandauer marked this conversation as resolved.
Show resolved Hide resolved
ThomasLandauer marked this conversation as resolved.
Show resolved Hide resolved
$line = $trace['line'];
}
}
$message = str_replace(['%%file%%', '%%line%%'], [$filePath, $line], $this->options['editorUrl']);
} else {
$message = codecept_relative_path(Descriptor::getTestFullName($failedTest));
}
$this->message("<error> Test </error> ")
->append(codecept_relative_path(Descriptor::getTestFullName($failedTest)))
->append($message)
ThomasLandauer marked this conversation as resolved.
Show resolved Hide resolved
->write();

if ($failedTest instanceof ScenarioDriven) {
Expand Down