Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverage: Don't attempt to set cookie domain when it is "localhost" #6210

Merged
merged 2 commits into from May 22, 2021
Merged

Coverage: Don't attempt to set cookie domain when it is "localhost" #6210

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1d5134
Don't attempt to set cookie domain when it is "localhost"
marcovtwout May 19, 2021
0ec6545
Remove accidental leftover line
marcovtwout May 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Codeception/Coverage/Subscriber/LocalServer.php
View file
Open in desktop
Expand Up @@ -201,8 +201,13 @@ protected function startCoverageCollection($testName)
// we need to separate coverage cookies by host; we can't separate cookies by port.
$cookieDomain = isset($c3Url['host']) ? $c3Url['host'] : 'localhost';
}

$cookieParams = [];
if ($cookieDomain !== 'localhost') {
$cookieParams['domain'] = $cookieDomain;
}

$this->module->setCookie(self::COVERAGE_COOKIE, $value, ['domain' => $cookieDomain]);
$this->module->setCookie(self::COVERAGE_COOKIE, $value, $cookieParams);

// putting in configuration ensures the cookie is used for all sessions of a MultiSession test

Expand Down