Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug proof: include and groups don't work together #5581

Closed
wants to merge 3 commits into from
Closed

Bug proof: include and groups don't work together #5581

wants to merge 3 commits into from

Conversation

Slamdunk
Copy link
Contributor

Hi, to make parallel tests work I need to split the into groups, but my tests are also split with the include directive.

It turns out the they don't work together: groups of tests of included suites seem ignored.

This PR is a bug proof, any tip on where to put hands to solve this is welcome.

The code has everything to test the bug, but for sake of completeness:

Expected output

$ ./codecept run -c tests/data/included_with_groups/
Codeception PHP Testing Framework v3.0.2
Powered by PHPUnit 8.2.5 by Sebastian Bergmann and contributors.
Running with seed: 

[Groups] para1 

[Jazz]: tests from /mnt/data/repos/Codeception/tests/data/included_with_groups/jazz

Jazz.unit Tests (1) ---------
✔ SimpleJazzTest: One (0.00s)
-----------------------------

[Shine]: tests from /mnt/data/repos/Codeception/tests/data/included_with_groups/shine

Shine.unit Tests (1) ---------
✔ SimpleShineTest: Two (0.00s)
------------------------------

Time: 113 ms, Memory: 10.00 MB

OK (2 tests, 2 assertions)

Actual output

$ ./codecept run -c tests/data/included_with_groups/ -g para1
Codeception PHP Testing Framework v3.0.2
Powered by PHPUnit 8.2.5 by Sebastian Bergmann and contributors.
Running with seed: 

[Groups] para1 

[Jazz]: tests from /mnt/data/repos/Codeception/tests/data/included_with_groups/jazz

Jazz.unit Tests (0) ----------
------------------------------

[Shine]: tests from /mnt/data/repos/Codeception/tests/data/included_with_groups/shine

Shine.unit Tests (0) ---------
------------------------------

Time: 103 ms, Memory: 10.00 MB

No tests executed!

@Naktibalda
Copy link
Member

@Slamdunk Some relevant changes were implemented in 4.1.24 (#6292) and 4.1.27 (#6302)

Please check if this issue was fixed.

@Slamdunk Slamdunk changed the base branch from 3.0 to 4.1 April 5, 2022 12:36
@Slamdunk Slamdunk closed this Apr 5, 2022
@Slamdunk Slamdunk reopened this Apr 5, 2022
@Slamdunk
Copy link
Contributor Author

Slamdunk commented Apr 5, 2022

@Naktibalda rebased and adapted to 4.1 branch: issue still present 😟

@Slamdunk Slamdunk closed this by deleting the head repository Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants