Avoid removing required fields in cookies. (#5470)

Codeception · Apr 21, 2019 · 2b17a54 · 2b17a54
1 parent 15281bb
commit 2b17a54
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/Codeception/Module/WebDriver.php b/src/Codeception/Module/WebDriver.php
@@ -825,13 +825,17 @@ public function setCookie($cookie, $value, array $params = [])
             }
         }
         // #5401 Supply defaults, otherwise chromedriver 2.46 complains.
-        $params = array_filter($params);
-        $params += [
+        $defaults = [
             'path' => '/',
             'expiry' => time() + 86400,
             'secure' => false,
             'httpOnly' => false,
         ];
+        foreach ($defaults as $key => $default) {
+            if (empty($params[$key])) {
+                $params[$key] = $default;
+            }
+        }
         $this->webDriver->manage()->addCookie($params);
         $this->debugSection('Cookies', json_encode($this->webDriver->manage()->getCookies()));
     }