Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update integration specs #303

Merged
merged 1 commit into from Oct 20, 2020
Merged

Update integration specs #303

merged 1 commit into from Oct 20, 2020

Conversation

dnkoutso
Copy link
Contributor

@dnkoutso dnkoutso commented Oct 20, 2020 •
edited

@dnkoutso dnkoutso mentioned this pull request Oct 20, 2020
Merged
dnkoutso
dnkoutso commented Oct 20, 2020
View reviewed changes
install_add_pod/after/Pods/Pods.xcodeproj
@@ -50,7 +50,6 @@ Targets:
Build Settings:
ARCHS: "$(ARCHS_STANDARD_64_BIT)"
CLANG_ENABLE_OBJC_WEAK: 'NO'
CODE_SIGN_IDENTITY: iPhone Developer
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine to be removed from Pods.xcodeproj. We set it in CocoaPods to whichever targets we need.

dnkoutso
dnkoutso commented Oct 20, 2020
View reviewed changes
install_add_pod/after/Pods/Pods.xcodeproj
@@ -218,6 +212,7 @@ Build Configurations:
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF: 'YES'
CLANG_WARN_OBJC_LITERAL_CONVERSION: 'YES'
CLANG_WARN_OBJC_ROOT_CLASS: YES_ERROR
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER: 'YES'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct. Again we set this to 'NO' for the pod target xcconfig. This is just the setting for the default Pods.xcodeproj.

@dnkoutso dnkoutso changed the base branch from master to 1-10-stable October 20, 2020 17:47
@dnkoutso dnkoutso merged commit 0be66c3 into 1-10-stable Oct 20, 2020
@dnkoutso dnkoutso deleted the bump_xcodeproj119 branch October 20, 2020 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amorde amorde amorde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dnkoutso @amorde