Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug of Git shallow cloning is not used when branch is set #106 #111

Closed
wants to merge 13 commits into from
Closed

Conversation

dimohamdy
Copy link

@dimohamdy
Copy link
Author

@fabiopelosin Can you check this PR?

@segiddins
Copy link
Member

Can you please add a test that covers behavior in this case? Thanks!

@dimohamdy
Copy link
Author

@segiddins I will

@dimohamdy
Copy link
Author

@segiddins I add a unit-test for it

@dimohamdy
Copy link
Author

@segiddins Can you check the PR Please?

@dimohamdy
Copy link
Author

dimohamdy commented Jul 13, 2021

@segiddins @fabiopelosin Any update or plan to merge this PR?

@dnkoutso
Copy link
Contributor

@dimohamdy please rebase and squash into a single commit.

Add a changelog entry and make sure you rebased on latest master.

@dimohamdy
Copy link
Author

@dnkoutso Please check the new PR #117 and I will close this one

@dnkoutso dnkoutso closed this Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants