Provide option to look into xcconfigs for common build settings. #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnkoutso
force-pushed
the
common_build_settings_xcconfig
branch
2 times, most recently
from
52b3229
to
27d8383
Compare
1 task
dnkoutso
force-pushed
the
common_build_settings_xcconfig
branch
from
27d8383
to
3805f93
Compare
amorde
approved these changes
Oct 30, 2019
segiddins
reviewed
Oct 30, 2019
| @@ -83,8 +87,8 @@ def resolved_build_setting(key, resolve_against_xcconfig = false) | |||
| # | |||
| # @return [String] The value of the build setting. | |||
| # | |||
| def common_resolved_build_setting(key) | |||
| values = resolved_build_setting(key).values.compact.uniq | |||
| def common_resolved_build_setting(key, resolve_against_xcconfig = false) | |||
There was a problem hiding this comment.
can this please be a keyword argument?
dnkoutso
force-pushed
the
common_build_settings_xcconfig
branch
from
3805f93
to
4ca29ab
Compare
|
Done, spoke offline that this is good to merge after changing to use keyword argument. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See CocoaPods/CocoaPods#9233 for more info