Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix duplicate compute dependencies #158

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jseanj
Copy link

@jseanj jseanj commented Sep 24, 2021

possibility_set has included all dependencies, so there is no need to duplicate compute dependencies.

@dnkoutso
Copy link
Contributor

hi there, what issue does this fix and can you add a test? or is it a performance improvement?

@jseanj
Copy link
Author

jseanj commented Sep 24, 2021

hi there, what issue does this fix and can you add a test? or is it a performance improvement?

The issue is possibility_set has cached the dependencies for possibility, so no need to re-acquire the dependencies.

I think it's a performance improvement that is not obvious, because the podspec usually doesn't have a lot of dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants