Support On-Demand Resource #622
Conversation
|
To provide more context: @JunyiXie has written an excellent blog post summarising the changes necessary to I'm looking forward to this PR! |
| # paths of the on_demand_resources to copy and the values the paths of | ||
| # the on_demand_resources that should be copied. | ||
| # | ||
| spec_attr_accessor :on_demand_resources |
There was a problem hiding this comment.
I think we would want this to be a Hash that allows Pod authors to specify the tag (see my comment here)
example:
s.on_demand_resources = {
'Tag1' => ['file1.png', 'file2.png']
}we also may need to provide a way for Pod authors to specify the category of the tag. The category determines how the resource gets fetched. To quote the docs:
Initial install tags. The resources are downloaded at the same time as the app. The size of the resources is included in the total size for the app in the App Store. The tags can be purged when they are not being accessed by at least one NSBundleResourceRequest object.
Prefetch tag order. The resources start downloading after the app is installed. The tags will be downloaded in the order in which they are listed in the Prefetched tag order group.
Dowloaded only on demand. The tags are downloaded when requested by the app.
There was a problem hiding this comment.
good idea. I will refer to your design for implementation.
|
Thanks for working on this! I think there's some additional questions we need to answer before this can land, but really appreciate you taking the time to investigate this, and @shirakaba thank you for helping facilitate review |
|
Thanks for suggestions, I modified the implementation of podspec dsl. @amorde |
|
Commenting to say I haven't forgotten about this! Have been taking a break, need a bit more time to review. Thank you for your patience 🙏 |
|
|
||
| * Support On-Demand Resource | ||
| [JunyiXie](https://github.com/JunyiXie) | ||
| [#issue_number](https://github.com/CocoaPods/Core/pull/622) |
There was a problem hiding this comment.
please make this 622 instead of #issue_number
| @@ -1370,6 +1390,7 @@ def dependency=(args) | |||
| :file_patterns => true, | |||
| :singularize => true | |||
|
|
|||
|
|
|||
| # | ||
| # @return [Hash] the resources. | ||
| # | ||
| def _prepare_on_demand_resources(value) |
There was a problem hiding this comment.
can you please add a test for this logic?
|
superseded by #690 |
CocoaPods/CocoaPods#9606