Fix vendored .bcsymbolmap on new build system #9734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice start! can you ensure I have access maybe i can take over it and continue it? |
|
Thanks for taking the time to investigate this 🙏 |
dnkoutso
force-pushed
the
fix_vendored_bcsymbolmap
branch
2 times, most recently
from
25ef334
to
ac34fc3
Compare
dnkoutso
reviewed
May 22, 2020
dnkoutso
force-pushed
the
fix_vendored_bcsymbolmap
branch
2 times, most recently
from
42a382a
to
a5a72ef
Compare
dnkoutso
reviewed
May 22, 2020
dnkoutso
force-pushed
the
fix_vendored_bcsymbolmap
branch
2 times, most recently
from
143a3cb
to
ce3581f
Compare
dnkoutso
force-pushed
the
fix_vendored_bcsymbolmap
branch
8 times, most recently
from
db00a9d
to
5d3a2fe
Compare
dnkoutso
reviewed
May 22, 2020
| if dsym_paths.empty? | ||
| script_phase = native_target.shell_script_build_phases.find { |bp| bp.name && bp.name.end_with?(UserProjectIntegrator::TargetIntegrator::COPY_DSYM_FILES_PHASE_NAME) } | ||
| if dsym_paths.empty? && bcsymbolmap_paths.empty? | ||
| script_phase = native_target.shell_script_build_phases.find do |bp| |
There was a problem hiding this comment.
just formatting to make line smaller, no change
dnkoutso
force-pushed
the
fix_vendored_bcsymbolmap
branch
6 times, most recently
from
2ec710e
to
cd147bf
Compare
amorde
approved these changes
May 22, 2020
dnkoutso
force-pushed
the
fix_vendored_bcsymbolmap
branch
from
cd147bf
to
25ae58e
Compare
…to Copy dSYMs phase
dnkoutso
force-pushed
the
fix_vendored_bcsymbolmap
branch
from
25ae58e
to
748b0db
Compare
|
@dnkoutso thanks so much for finishing this! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌈 Fix for #9419
I moved the .bcsymbolmap copy command out of the Embed Frameworks phase and into the new Copy dSYMs phase that was added in #9547.
I got a good start on this but I'm not sure if I have bandwidth to take it over the finish line. I haven't used submodules before so I'm not sure how to get those changes to show up in this PR. I'm also unsure how to update the "after" folder in the integration test fixtures with a new xcproj file. Happy for a maintainer to clean this up if they are interested.
edit by dnkoutso:
integration specs CocoaPods/cocoapods-integration-specs#282