Apply Xcode 11 XCTUnwrap fix to library and framework targets.
#9500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnkoutso
commented
Jan 21, 2020
| @@ -13,13 +13,18 @@ def pod_target(spec, target_definition) | |||
| end | |||
|
|
|||
| before do | |||
| @target_definition = fixture_target_definition | |||
| project_path = SpecHelper.create_sample_app_copy_from_fixture('SampleProject') | |||
There was a problem hiding this comment.
this test setup was not using an actual project to the aggregate target. Now it does.
dnkoutso
force-pushed
the
xctunwrap_fix
branch
from
5603f1d
to
752b5ed
Compare
dnkoutso
commented
Jan 21, 2020
| @@ -190,7 +195,7 @@ def pod_target(spec, target_definition) | |||
| end | |||
|
|
|||
| it 'links the pod targets with the aggregate target' do | |||
| @xcconfig.to_hash['OTHER_LDFLAGS'].should.include '-l"BananaLib-Pods"' | |||
| @xcconfig.to_hash['OTHER_LDFLAGS'].should.include '-l"BananaLib-Pods-SampleProject"' | |||
There was a problem hiding this comment.
this is correct since we are now integrating on a real project and a real user target.
dnkoutso
force-pushed
the
xctunwrap_fix
branch
from
752b5ed
to
bc34161
Compare
dnkoutso
commented
Jan 22, 2020
dnkoutso
force-pushed
the
xctunwrap_fix
branch
from
bc34161
to
a3eea75
Compare
dnkoutso
commented
Jan 22, 2020
dnkoutso
force-pushed
the
xctunwrap_fix
branch
from
a3eea75
to
18d8b32
Compare
dnkoutso
force-pushed
the
xctunwrap_fix
branch
6 times, most recently
from
b98a518
to
f45d1fc
Compare
dnkoutso
force-pushed
the
xctunwrap_fix
branch
2 times, most recently
from
a43f02b
to
f511e31
Compare
justinseanmartin
approved these changes
Jan 23, 2020
segiddins
reviewed
Jan 23, 2020
dnkoutso
force-pushed
the
xctunwrap_fix
branch
from
f511e31
to
7cbcc9f
Compare
dnkoutso
changed the title
XCTUnwrap fix to library and framwork targets.XCTUnwrap fix to library and framework targets.
dnkoutso
force-pushed
the
xctunwrap_fix
branch
2 times, most recently
from
02ef6cc
to
d2b5d91
Compare
segiddins
reviewed
Jan 27, 2020
dnkoutso
force-pushed
the
xctunwrap_fix
branch
3 times, most recently
from
ac1072e
to
67ac0b9
Compare
dnkoutso
force-pushed
the
xctunwrap_fix
branch
from
67ac0b9
to
5bacd5e
Compare
segiddins
approved these changes
Jan 28, 2020
dnkoutso
force-pushed
the
xctunwrap_fix
branch
from
5bacd5e
to
60a2285
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://developer.apple.com/documentation/xcode_release_notes/xcode_11_release_notes
Integration specs: CocoaPods/cocoapods-integration-specs#266
This fixes it for both user targets that have this issue and fixes also for pod targets.